Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #2604

Closed
wants to merge 10 commits into from
Closed

test #2604

wants to merge 10 commits into from

Conversation

francoisferrand
Copy link
Contributor

  • gha: bump codecov@v5
  • Fix dockerfile lint issues
  • Do not delete Zenko object when not in OOB
  • Use x-amz-meta-scal-version-id when ingesting object
  • debug
  • Properly handle archive
  • fix codecov notification

Make OOB location-aware, and thus do not delete the Zenko object when it
gets removed from S3C by gc at the end of the transition.

Issue: BB-590
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 91.22807% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.57%. Comparing base (ca50af2) to head (5e429ef).

Files with missing lines Patch % Lines
lib/models/DeleteOpQueueEntry.js 50.00% 2 Missing ⚠️
lib/models/QueueEntry.js 0.00% 2 Missing ⚠️
extensions/mongoProcessor/MongoQueueProcessor.js 98.03% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/queuePopulator/LogReader.js 29.27% <ø> (ø)
extensions/mongoProcessor/MongoQueueProcessor.js 69.41% <98.03%> (+6.69%) ⬆️
lib/models/DeleteOpQueueEntry.js 62.50% <50.00%> (+52.50%) ⬆️
lib/models/QueueEntry.js 67.64% <0.00%> (-2.05%) ⬇️

... and 2 files with indirect coverage changes

Components Coverage Δ
Bucket Notification 18.51% <ø> (ø)
Core Library 62.08% <33.33%> (+0.16%) ⬆️
Ingestion 69.09% <98.03%> (+1.55%) ⬆️
Lifecycle 47.09% <ø> (ø)
Oplog Populator 84.20% <ø> (ø)
Replication 51.01% <ø> (ø)
Bucket Scanner 85.60% <ø> (ø)
@@                Coverage Diff                @@
##           bugfix/BB-641    #2604      +/-   ##
=================================================
+ Coverage          55.34%   55.57%   +0.23%     
=================================================
  Files                198      198              
  Lines              12925    12957      +32     
=================================================
+ Hits                7153     7201      +48     
+ Misses              5762     5746      -16     
  Partials              10       10              
Flag Coverage Δ
api:retry 9.59% <0.00%> (-0.03%) ⬇️
api:routes 9.49% <0.00%> (-0.03%) ⬇️
bucket-scanner 85.60% <ø> (ø)
ingestion 12.81% <91.22%> (+0.35%) ⬆️
lib 7.49% <0.00%> (-0.03%) ⬇️
lifecycle 19.37% <0.00%> (-0.07%) ⬇️
notification 0.88% <0.00%> (-0.01%) ⬇️
replication 18.83% <0.00%> (-0.05%) ⬇️
unit 5.12% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@francoisferrand francoisferrand force-pushed the improvement/BB-590 branch 7 times, most recently from e45e3d1 to 485b0df Compare December 24, 2024 16:53
This custom (but reserved) user metadata field is set by Cloudserver
when restoring cold object in OOB bucket.

Issue: BB-590
@francoisferrand francoisferrand force-pushed the improvement/BB-590 branch 4 times, most recently from 3a602d8 to 60d5798 Compare December 26, 2024 17:54
Instead of rebuilding the whole metadata on updates, simply update the
required fields, i.e. tags.

This also fixes subtle issues, where some fields from Zenko may be
overwritten when some operations are performed on s3c.

Issue: BB-590
If the bucket has no lifecycle or notification configuration, we don't
need the oplog update, and can skip it to lower the load on mongo.

Issue: BB-590
An oplog update is only required when the object is archived, instead of
when lifecycle is enabled: so fix the condition to avoid extra
associated load.

The update is also required when bucket notification is enabled on the
bucket, no change there.

Issue: BB-590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant