-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test #2604
Closed
Closed
test #2604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
francoisferrand
commented
Dec 20, 2024
- gha: bump codecov@v5
- Fix dockerfile lint issues
- Do not delete Zenko object when not in OOB
- Use x-amz-meta-scal-version-id when ingesting object
- debug
- Properly handle archive
- fix codecov notification
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 2 files with indirect coverage changes
@@ Coverage Diff @@
## bugfix/BB-641 #2604 +/- ##
=================================================
+ Coverage 55.34% 55.57% +0.23%
=================================================
Files 198 198
Lines 12925 12957 +32
=================================================
+ Hits 7153 7201 +48
+ Misses 5762 5746 -16
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. |
francoisferrand
force-pushed
the
improvement/BB-590
branch
7 times, most recently
from
December 24, 2024 16:53
e45e3d1
to
485b0df
Compare
This custom (but reserved) user metadata field is set by Cloudserver when restoring cold object in OOB bucket. Issue: BB-590
francoisferrand
force-pushed
the
improvement/BB-590
branch
4 times, most recently
from
December 26, 2024 17:54
3a602d8
to
60d5798
Compare
Issue: BB-590
Instead of rebuilding the whole metadata on updates, simply update the required fields, i.e. tags. This also fixes subtle issues, where some fields from Zenko may be overwritten when some operations are performed on s3c. Issue: BB-590
If the bucket has no lifecycle or notification configuration, we don't need the oplog update, and can skip it to lower the load on mongo. Issue: BB-590
An oplog update is only required when the object is archived, instead of when lifecycle is enabled: so fix the condition to avoid extra associated load. The update is also required when bucket notification is enabled on the bucket, no change there. Issue: BB-590
francoisferrand
force-pushed
the
improvement/BB-590
branch
from
December 27, 2024 12:00
2b0706a
to
5e429ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.